Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): MultiSelect empty line when non empty placeholder and valueContent #9127

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(kit): MultiSelect empty line when non empty placeholder and valueContent #9127

merged 2 commits into from
Sep 23, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 22, 2024

Close #9112

@github-actions github-actions bot added the v3 label Sep 22, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 22, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e0fdd06):

https://taiga-ui--pr9127-mdlufy-multi-select-gdekogax.web.app

(expires Tue, 24 Sep 2024 08:11:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 22, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +397.42KB +10%
✅ demo/browser/vendor.(hash).js
 +214.55KB +10%
✅ demo/browser/runtime.(hash).js
 +42KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.22KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +670.59KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.45MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@mdlufy mdlufy changed the title [WIP] fix(kit): MultiSelect empty line when non empty placeholder and valueContent fix(kit): MultiSelect empty line when non empty placeholder and valueContent Sep 23, 2024
@mdlufy mdlufy marked this pull request as ready for review September 23, 2024 07:29
@mdlufy mdlufy merged commit 28f1845 into v3.x Sep 23, 2024
32 of 33 checks passed
@mdlufy mdlufy deleted the mdlufy/multi-select-v3 branch September 23, 2024 09:03
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner

Assignees

@mdlufy mdlufy

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdlufy @waterplea @splincode